Skip to content

chore: Improve flaky tests and add error messages #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chrfwow merged 3 commits into from
Dec 18, 2025
Merged

chore: Improve flaky tests and add error messages #1653

chrfwow merged 3 commits into from
Dec 18, 2025

Conversation

@chrfwow
Copy link
Contributor

@chrfwow chrfwow commented Nov 20, 2025

Makes some tests more robust

@chrfwow chrfwow requested a review from a team as a code owner November 20, 2025 12:41
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 20, 2025

Summary of Changes

Hello @chrfwow, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the stability and diagnostic capabilities of existing tests. It addresses flakiness in a specific test by introducing more precise timing measurements and detailed error reporting. Additionally, it enhances the robustness of end-to-end tests by adopting a thread-safe data structure for event collection, ensuring reliable behavior in concurrent environments.

Highlights

  • Improved Test Robustness: Enhanced the callingInitialize_wakesUpWaitingThread test in FlagdProviderSyncResourcesTest.java by replacing a simple boolean flag with a precise time measurement (AtomicLong waitTime). This change allows for more accurate assessment of the waiting duration and provides a detailed error message upon failure, making the test less flaky and easier to debug.
  • Enhanced Concurrency for E2E Events: Switched the event collection mechanism in end-to-end tests from LinkedList to ConcurrentLinkedQueue in State.java and EventSteps.java. This change improves thread safety and performance for concurrent event handling, making the e2e tests more reliable in multi-threaded scenarios.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 20, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves test robustness by addressing potential concurrency issues and enhancing assertion messages. The change from LinkedList to ConcurrentLinkedQueue for handling events in E2E tests is a good move to prevent race conditions. The assertion message in FlagdProviderSyncResourcesTest is now more informative. I've added a couple of suggestions: one to improve test performance and readability by using a lazy-evaluated assertion message, and another to remove a redundant and potentially problematic re-initialization of a shared state field, which could itself introduce flakiness.

@chrfwow chrfwow enabled auto-merge (squash) November 20, 2025 16:21
@chrfwow @toddbaert
Improve tests
e593d30 
Signed-off-by: christian.lutnik <[email protected]>
@chrfwow @toddbaert
Improve tests
6a11bd6 
Signed-off-by: christian.lutnik <[email protected]>
@toddbaert toddbaert changed the title feat: Improve flaky tests and add error messages chore: Improve flaky tests and add error messages Dec 17, 2025
@toddbaert
fixup: pr feedback
a77b932 
Signed-off-by: Todd Baert <[email protected]>
@chrfwow chrfwow merged commit 48df358 into open-feature:main Dec 18, 2025
5 checks passed
@openfeaturebot openfeaturebot mentioned this pull request Dec 17, 2025
Merged
@chrfwow chrfwow deleted the fix-flaky-tests branch January 7, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aepfli aepfli aepfli approved these changes

@beeme1mr beeme1mr Awaiting requested review from beeme1mr

@Kavindu-Dodan Kavindu-Dodan Awaiting requested review from Kavindu-Dodan

@thisthat thisthat Awaiting requested review from thisthat

@toddbaert toddbaert Awaiting requested review from toddbaert

+2 more reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@alexandraoberaigner alexandraoberaigner alexandraoberaigner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beeme1mr beeme1mr

@thisthat thisthat

@Kavindu-Dodan Kavindu-Dodan

@toddbaert toddbaert

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@chrfwow @aepfli @toddbaert @alexandraoberaigner @beeme1mr @thisthat @Kavindu-Dodan